Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added logic to manually set server_url and app_id for staging-p2p #133

Merged
merged 2 commits into from
Jun 14, 2024
Merged

feat: added logic to manually set server_url and app_id for staging-p2p #133

merged 2 commits into from
Jun 14, 2024

Conversation

shayan-deriv
Copy link
Contributor

No description provided.

src/constants/url.ts Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 9513525085

Details

  • 5 of 7 (71.43%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 74.905%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/constants/url.ts 5 7 71.43%
Totals Coverage Status
Change from base Build 9511935018: -0.03%
Covered Lines: 4638
Relevant Lines: 5602

💛 - Coveralls

Copy link

Preview Link: https://shayan-FEQ-2378-set1.p2p-standalone.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview
Action URL Visit Action

@ali-hosseini-deriv ali-hosseini-deriv merged commit 13b6710 into deriv-com:master Jun 14, 2024
3 checks passed
@coveralls
Copy link

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 9514153483

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 6 of 8 (75.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.07%) to 75.0%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/constants/url.ts 6 8 75.0%
Files with Coverage Reduction New Missed Lines %
src/components/AppHeader/MobileMenu/index.tsx 1 89.29%
src/components/AppHeader/MobileMenu/MobileMenuConfig.tsx 4 60.0%
src/components/AppHeader/MobileMenu/MenuContent.tsx 4 27.78%
Totals Coverage Status
Change from base Build 9511935018: 0.07%
Covered Lines: 4635
Relevant Lines: 5590

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants